[wanproxy/wanproxy] 40d011: Limit the period over which messages are collapsed...

Juli Mallett juli at clockworksquid.com
Tue Apr 7 15:06:17 PDT 2015


  Branch: refs/heads/master
  Home:   https://github.com/wanproxy/wanproxy
  Commit: 40d011e8c47b91fbbfa0fbb15adb2f3d2c1048c4
      https://github.com/wanproxy/wanproxy/commit/40d011e8c47b91fbbfa0fbb15adb2f3d2c1048c4
  Author: Juli Mallett <juli at clockworksquid.com>
  Date:   2015-04-07 (Tue, 07 Apr 2015)

  Changed paths:
    M common/log.cc

  Log Message:
  -----------
  Limit the period over which messages are collapsed.


  Commit: 2004b1c3b1882ee63e0fb4c1246d101393b0ad6f
      https://github.com/wanproxy/wanproxy/commit/2004b1c3b1882ee63e0fb4c1246d101393b0ad6f
  Author: Juli Mallett <juli at clockworksquid.com>
  Date:   2015-04-07 (Tue, 07 Apr 2015)

  Changed paths:
    M io/socket/socket_uinet.cc
    M io/socket/socket_uinet.h

  Log Message:
  -----------
  Resolve locking issues in SocketUinet.

SocketUinet has had some historical issues (as do other codebases
using libuinet callbacks) with lock order, which this commit
resolves by using a special mutex to defer work from upcalls if
the locks cannot be acquired safely.

This code, while an improvement, may still have issues, but at
least seems to resolve the most common deadlocks and races which
were present in SocketUinet previously.

Other work in WANProxy may make some of this redundant in time,
particularly if callbacks and actions become more permanent, if
locking is added to callbacks (with interlock on dispatch),
etc.


Compare: https://github.com/wanproxy/wanproxy/compare/657d666db24e...2004b1c3b188


More information about the wanproxy mailing list